patch DGUSScreenHandler::init() to handle REINIT_NOISY_LCD#28459
Open
ellensp wants to merge 1 commit into
Open
patch DGUSScreenHandler::init() to handle REINIT_NOISY_LCD#28459ellensp wants to merge 1 commit into
ellensp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With REINIT_NOISY_LCD enabled, removing the sdcard on dgus_e3s1pro or dgus_reloaded resulted in the boot screen being redisplayed with no way out of it.
The same bug was in both user interfaces.
Updated DGUSScreenHandler.cpp to check for booted flag and, after 'booted' is true, call triggerFullUpdate()
Requirements
REINIT_NOISY_LCD, SDSUPPORT with RELOADED or E3S1PRO UI
Benefits
Works as expected; can remove and insert the SD card without getting the boot screen.
Configurations
Eg from the issue
Configuration Files E5Plus SD Card Bug.zip
Related Issues